-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor and unit test switch.go; various other changes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch.go refactor and testing
Refactor code in switch.go to be unit-testable. Add some unit tests in switch_test.go.
Deprecate -ignore-pattern flag
The -ignore-pattern flag is deprecated and has no effect. Add -ignore-enum-members,
which has the same behavior, instead. Update the docs accordingly.
Support checking strategies
The new -checking-strategy flag can be used to specify a checking strategy, one of
"value" or "name". The default strategy is "value", which retains the existing behavior,
of requiring every enum member value to be listed in a switch statement.
The "name" strategy requires every enum member name to be listed in a switch
statement.
Add related docs in doc.go.
Add tests for this change in the testdata packages "duplicateenumvalue/...".
Analyzer does not suggest fixes
The "-fix" flag is now a no-op. The analyzer no longer reports any suggested fixes.
Also remove source code and testdata related to this flag. Update doc.go
accordingly.
CI
Include Go 1.14 explicitly in CI matrix. (This is to match with the go version in go.mod.)
Repo documentation
Add a separate CONTRIBUTING file. General corrections and updates to README.
Other changes
Improve gob-compatibility testing of fact types.