-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use storage scope for annotations's text part and improve annotation regex. #43
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 69.23% 69.97% +0.74%
==========================================
Files 13 13
Lines 481 493 +12
==========================================
+ Hits 333 345 +12
Misses 148 148
Continue to review full report at Codecov.
|
dist/Kotlin.JSON-tmLanguage
Outdated
"match": "@[a-zA-Z_]\\w*", | ||
"name": "meta.annotation.kotlin" | ||
"match": "@(?:(?:file|property|field|get|set|receiver|param|setparam|delegate)\\s*:\\s*)?[a-zA-Z_]\\w*", | ||
"name": "storage.type.annotation.kotlin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a comment for discussion here #42 (comment). That would need to be addressed before this gets merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any updates? 🤔
Oops closed by mistake, did not knew master is up on a PR. |
Fixes #42 by merging use-site annotation regex with one without use-site.
Also moves the scope of the
meta.annotation.kotlin
tostorage.type.annotation.kotlin
for the name of the annotation (excluding the braces).