Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use storage scope for annotations's text part and improve annotation regex. #43

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Animeshz
Copy link
Contributor

@Animeshz Animeshz commented Feb 9, 2021

Fixes #42 by merging use-site annotation regex with one without use-site.

Also moves the scope of the meta.annotation.kotlin to storage.type.annotation.kotlin for the name of the annotation (excluding the braces).

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #43 (46e2761) into master (5738095) will increase coverage by 0.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   69.23%   69.97%   +0.74%     
==========================================
  Files          13       13              
  Lines         481      493      +12     
==========================================
+ Hits          333      345      +12     
  Misses        148      148              
Impacted Files Coverage Δ
src/ident.YAML-tmLanguage 100.00% <ø> (ø)
src/keywords.YAML-tmLanguage 60.00% <ø> (ø)
src/annotations.YAML-tmLanguage 100.00% <100.00%> (ø)
src/generic.YAML-tmLanguage 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5738095...46e2761. Read the comment docs.

"match": "@[a-zA-Z_]\\w*",
"name": "meta.annotation.kotlin"
"match": "@(?:(?:file|property|field|get|set|receiver|param|setparam|delegate)\\s*:\\s*)?[a-zA-Z_]\\w*",
"name": "storage.type.annotation.kotlin"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment for discussion here #42 (comment). That would need to be addressed before this gets merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates? 🤔

@Animeshz
Copy link
Contributor Author

Oops closed by mistake, did not knew master is up on a PR.

@Animeshz Animeshz reopened this May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotations with qualifier and braces are not handled.
2 participants