Variability #381
Variability #381
Conversation
…smif prepare. Based on a scenario file template, create multiple scenario variants
… the smif prepare command. Issue #364
- Bit of cleaning for cli.prepare_scenario and cli.prepare_model_run
… the upper level Store class and not the lower file store YamlConfigStore class.
…opulation_variants.yml scenario to test variability within sample_project #364
…1 variant (or 0 variant) #364
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 71.09% 71.44% +0.34%
==========================================
Files 60 60
Lines 5342 5400 +58
Branches 661 669 +8
==========================================
+ Hits 3798 3858 +60
+ Misses 1448 1446 -2
Partials 96 96
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks @tlestang - this will be super useful for helping with larger sets of variants, and it's a neat step forward in thinking through smif's interface for manipulating all the config.
I've suggested a few changes below - apologies, it's come out as a whole pile of one-line changes, I thought I'd experiment with the GitHub interface. You should be able to skim through them and commit in a couple of batches:
- style/clarity improvements of
Store.prepare_scenario, which also remove the need for the first-item special case in the tests - read and write strategies in
Store.prepare_model_runs, which mean the test setup needs to write strategies too
also removes the need for the first-item special case in the tests
- so the test setup needs to write strategies too
The variability functionality (see #353) allows users of smif to perform an ensemble of model runs, based on an ensemble of scenario variants. In this case the command
smif runin invoked with a batch file (#179) that contains the list of model runs.This pull request mainly adds the
smif prepare-runandsmif prepare-scenariocommands (#364 ).