Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Upgrade to go-redis@v7, redigo@v1.8.2, go@1.14 #43

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

Shivam010
Copy link
Collaborator

Closes #37

@Shivam010 Shivam010 requested a review from nitishm July 15, 2020 18:54
@Shivam010 Shivam010 self-assigned this Jul 15, 2020
@coveralls
Copy link

coveralls commented Jul 15, 2020

Pull Request Test Coverage Report for Build 99

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 96: 0.0%
Covered Lines: 118
Relevant Lines: 118

💛 - Coveralls

Comment on lines +3 to +4
go 1.14

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Go version is not changed intentionally. I use 1.14 and whenever there is no version specified in go.mod file, it automatically adds the version.

What do you think of the change?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be a problem IMO

Comment on lines +6 to +7
github.com/go-redis/redis/v7 v7.4.0
github.com/gomodule/redigo v1.8.2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to go-redis version, I have also upgraded redigo version. As I personally used go-rejson with the upgraded version of redigo and it has no difference.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shivam010 Shivam010 merged commit 95b41da into master Jul 16, 2020
@Shivam010 Shivam010 deleted the bump branch July 16, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Go Redis V7 Client Problem
3 participants