Adds a module for logging requests #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BlackMinou <romain.chanoir@viacesi.fr>
| print "{class_name} return: uri={truncated_uri}" | ||
| else | ||
| super | ||
| end |
There was a problem hiding this comment.
cf @R4PaSs
if not debug then
super
return
end
# rest of the code
| # limitations under the License. | ||
|
|
||
| # logs requests | ||
| module logging |
There was a problem hiding this comment.
I would prefer log as in import nitcorn::log, it's shorter and cleaner.
Suggestion to improve the doc: Services inserting a timestamp in all prints and to log each requests
|
+1 Closes #1802. |
privat
added a commit
that referenced
this pull request
Dec 1, 2015
Title pretty much says it all Pull-Request: #1869 Reviewed-by: Alexis Laferrière <alexis.laf@xymus.net> Reviewed-by: Jean Privat <jean@pryen.org> Reviewed-by: Lucas Bajolet <r4pass@hotmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title pretty much says it all