Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customisable Django Forms #88

Closed
Slixe opened this issue Jan 23, 2024 · 2 comments
Closed

Customisable Django Forms #88

Slixe opened this issue Jan 23, 2024 · 2 comments

Comments

@Slixe
Copy link

Slixe commented Jan 23, 2024

Hey there,
Thanks for your amazing project !
I would like to ask if you would be agree to use utils.import_attr and expose USER_CREDENTIAL_FORM (and others) to have dynamic choice of which form to use directly in settings.py ?

That would be a great feature and would prevent people like me to just overwrite it.

I can do a pull request if you're agree :)
nitmir added a commit that referenced this issue Apr 13, 2024
@nitmir
Allow forms to be overridden from settings. Fix #88
80a1eac
nitmir added a commit that referenced this issue Apr 13, 2024
@nitmir
Allow forms to be overridden from settings. Fix #88
17c54aa
@nitmir
Copy link
Owner

nitmir commented Apr 13, 2024

Hello,

Does 17c54aa seems acceptable to you ?

Cheers

@Slixe
Copy link
Author

Slixe commented Apr 13, 2024

hey there,

lgtm, thanks for your time ! :)

@nitmir nitmir closed this as completed in a2f10ff Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nitmir @Slixe