Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return more errors instead of panic #1

Merged
merged 8 commits into from
Apr 17, 2024
Merged

Conversation

DerInti
Copy link
Contributor

@DerInti DerInti commented Apr 16, 2024

Hi,

I use this module in an Prometheus Exporter for Fritzboxes and it works like a charm - but yields a panic in case of the tyniest unexpected situation. This is a take to react to failures when utilizing the library.

I have changed some minor stuff which should be kept apart by the different commits.

  • I just had to rename the module from gofitz to gofritz
  • the service-description of Fritzbox 7590 Rev. 1 is added
  • the codegen should not fail anymore, because of a missing stub (functions_register_test)
  • Errorhandling in the stub-template and most of the soap functions

‼️No generated code is committed.

@nitram509
Copy link
Owner

Thank you very much for your contribution 🚀

I will merge it straight and re-run the code generator (which needs some love first).

@nitram509 nitram509 merged commit db8bfd7 into nitram509:main Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants