Wrap base image builds with the nitric membrane and use base images for nitric run #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjholm
requested review from
asalkeld,
davemooreuws,
HomelessDinosaur and
jyecusch
Codecov ReportBase: 32.22% // Head: 27.08% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #359 +/- ##
===========================================
- Coverage 32.22% 27.08% -5.15%
===========================================
Files 52 52
Lines 4990 4560 -430
===========================================
- Hits 1608 1235 -373
+ Misses 3224 3208 -16
+ Partials 158 117 -41
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tjholm
force-pushed
the
feat/wrapped-builds
branch
from
3df358f
to
c9dc6c4
Compare
asalkeld
approved these changes
Oct 5, 2022
tjholm
force-pushed
the
feat/wrapped-builds
branch
from
1346b8d
to
20cc00a
Compare
chore: cleanup unused code. chore: Output container build logs to debug. chore: use shell format for javascript and python chore: fix copy of golang source files. chore: Make sure available services print. chore: consistently named docker files. chore: update .dockerignore to improve cache consistency for multiple functions. chore: make fmt. chore: update tests. chore: go mod tidy.
tjholm
force-pushed
the
feat/wrapped-builds
branch
from
20cc00a
to
d1bb044
Compare
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits:
nitric up(this should speed up deploy builds as well)nitric up(this should speed up deploy builds as well).nitric runprovides better indication of final build (base images are the same as production deployments).