Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch support #779

Merged
merged 12 commits into from
Oct 3, 2024
Merged

Batch support #779

merged 12 commits into from
Oct 3, 2024

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Aug 27, 2024

Still need to implement a local run/start implementation. This just includes collection code for deployments. With lots of duplication from services at the moment.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1186 lines in your changes missing coverage. Please review.

Project coverage is 2.64%. Comparing base (b605a39) to head (6bb7992).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/project/batch.go 0.00% 288 Missing ⚠️
pkg/project/project.go 0.00% 219 Missing ⚠️
pkg/collector/spec.go 0.00% 187 Missing ⚠️
pkg/collector/batch.go 0.00% 174 Missing ⚠️
pkg/cloud/batch/batch.go 0.00% 99 Missing ⚠️
pkg/cloud/cloud.go 0.00% 66 Missing ⚠️
pkg/dashboard/dashboard.go 0.00% 64 Missing ⚠️
pkg/cloud/gateway/gateway.go 0.00% 32 Missing ⚠️
pkg/collector/service.go 0.00% 13 Missing ⚠️
pkg/dashboard/handlers.go 0.00% 13 Missing ⚠️
... and 5 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #779      +/-   ##
========================================
- Coverage   2.95%   2.64%   -0.32%     
========================================
  Files         82      85       +3     
  Lines       9342   10442    +1100     
========================================
  Hits         276     276              
- Misses      9054   10154    +1100     
  Partials      12      12              
Flag Coverage Δ
unittests 2.64% <0.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tjholm and others added 8 commits September 25, 2024 10:58
get migration configs from batch services.

Add local batch plugin and runner interface.


update CLI batch plugin.

fix errors.

add batch container runs

minor updates.

cleanup

fmt.

update to latest batch core.

update to latest core.

remove debug statement.

Add batch builds to debug spec.

error when jobs are misconfigured.

consistent rename

rename run -> start

rename batches -> batch-services.


batch_path -> service_path
jyecusch
jyecusch previously approved these changes Oct 3, 2024
@tjholm tjholm marked this pull request as ready for review October 3, 2024 06:30
@tjholm tjholm merged commit 47630a9 into main Oct 3, 2024
3 of 6 checks passed
@tjholm tjholm deleted the jobs-rebase branch October 3, 2024 06:58
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.54.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants