Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use correct method override for BucketNotificationContext. #179

Merged
merged 1 commit into from
May 9, 2023

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented May 9, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 60.79% and project coverage change: -2.78 ⚠️

Comparison is base (0664462) 85.90% compared to head (e6b9ab0) 83.12%.

❗ Current head e6b9ab0 differs from pull request most recent head 2d262cd. Consider uploading reports for the commit 2d262cd to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
- Coverage    85.90%   83.12%   -2.78%     
===========================================
  Files           83       84       +1     
  Lines         1518     1624     +106     
  Branches       207      231      +24     
===========================================
+ Hits          1304     1350      +46     
- Misses         214      267      +53     
- Partials         0        7       +7     
Impacted Files Coverage Δ
src/api/storage/v0/storage.ts 96.87% <ø> (ø)
src/faas/v0/handler.ts 100.00% <ø> (ø)
src/resources/topic.ts 86.95% <ø> (ø)
src/faas/v0/context.ts 60.22% <16.00%> (-16.11%) ⬇️
src/faas/v0/start.ts 31.78% <25.92%> (-1.82%) ⬇️
src/resources/api.ts 84.03% <86.11%> (+0.70%) ⬆️
src/resources/bucket.ts 80.95% <91.66%> (+6.59%) ⬆️
src/api/events/v0/events.ts 98.30% <100.00%> (+0.02%) ⬆️
src/api/queues/v0/queues.ts 96.29% <100.00%> (-0.05%) ⬇️
src/resources/queue.ts 78.94% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tjholm tjholm changed the title fix: Use correct method override for BucketNotificationContext. chore: Use correct method override for BucketNotificationContext. May 9, 2023
@HomelessDinosaur HomelessDinosaur merged commit 10d6c0c into develop May 9, 2023
@HomelessDinosaur HomelessDinosaur deleted the fix/bucket-notifications branch May 9, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants