Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Websocket support #196

Merged
merged 6 commits into from
Jul 12, 2023
Merged

feat: Websocket support #196

merged 6 commits into from
Jul 12, 2023

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Jul 6, 2023

Adds websocket support to the node SDK.

Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple of comment changes

src/api/websocket/v0/websocket.ts Outdated Show resolved Hide resolved
src/api/websocket/v0/websocket.ts Outdated Show resolved Hide resolved
src/resources/websocket.test.ts Outdated Show resolved Hide resolved
src/resources/websocket.ts Outdated Show resolved Hide resolved
src/resources/websocket.ts Outdated Show resolved Hide resolved
src/resources/websocket.ts Outdated Show resolved Hide resolved
tjholm and others added 3 commits July 11, 2023 16:49
use correct base data type


add missing license headers


prettier


websocket resource tests


update jsdoc


remove raw client example.


remove commented out test
@tjholm tjholm marked this pull request as ready for review July 11, 2023 06:49
@tjholm tjholm requested a review from davemooreuws July 11, 2023 06:49
@tjholm tjholm merged commit 4481889 into develop Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants