Fix label in radio element #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the for attribute in label element to the id of the radio button instead of the name of the radio button field.
|
Realized there is event wiring issue with this patch. Closing and resubmitting new pull request to make labels for radio and checkboxes clickable without screwing up event wiring. |
tex
pushed a commit
to tex/nitrogen_core
that referenced
this pull request
Aug 9, 2012
Dropdown multiple
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using labels in HTML forms, the label is "clickable" (i.e. when the label is clicked the form control associated with it behaves as if it has been clicked) when the for attribute in the label element corresponds to the id attribute of the form field element.
Previously the radio element's label in Nitrogen 2.x was not clickable because the radio button markup did not have an id set. These changes fix that.