Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to download/fetch Gitlab Packages #128

Closed
kennyballou opened this issue Apr 8, 2021 · 11 comments
Closed

Unable to download/fetch Gitlab Packages #128

kennyballou opened this issue Apr 8, 2021 · 11 comments

Comments

@kennyballou
Copy link

I noticed geiser was marked broken when I tried to update to the latest commit in the overlay.

Looking over the latest commit, it appears to be the Gitlab fetcher is not finding packages? Manually trying the URL's generated in the output give me 404's, not 503's as the output indicates.

Maybe this isn't an issue for the overlay, but within fetcher in nixpkgs?

@terlar
Copy link

terlar commented Apr 9, 2021

This is not an issue with the fetcher in nixpkgs, but related to the update-time. I fixed this particular package by adding the following override (https://github.com/terlar/emacs-config/blob/master/overrides.nix#L22-L33):

  geiser = epkgs.melpaPackages.geiser.overrideAttrs (attrs: {
    src = fetchFromGitLab {
      owner = "emacs-geiser";
      repo = "geiser";
      rev = "d7ba81b402787e3315b40f60952f95816a1cf99c";
      sha256 = "sha256-we0un+EYB2ByA57g+TVMuP21HBmXRaTLt5JC4QWjGAE=";
    };

    meta = attrs.meta // {
      broken = false;
    };
  });

This of course is a temporary fix until the generated stuff is fixed.

@talyz
Copy link
Contributor

talyz commented Apr 12, 2021

This looks like a bug in emacs2nix. Reported in nix-community/emacs2nix#56.

kennyballou added a commit to kennyballou/emacs2nix that referenced this issue Apr 12, 2021
Use similar archive fetch URL as [fetchgitlab][0] from [nixpkgs][1].

[0]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchgitlab/default.nix

[1]: https://github.com/NixOS/nixpkgs

This resolves nix-community#56 and nix-community/emacs-overlay#128.

Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
kennyballou added a commit to kennyballou/emacs2nix that referenced this issue Apr 12, 2021
Use similar archive fetch URL as [fetchgitlab][0] from [nixpkgs][1].
This archive scheme is documented in the [GitLab API docs][2].

[0]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchgitlab/default.nix

[1]: https://github.com/NixOS/nixpkgs

[3]: https://docs.gitlab.com/ce/api/repositories.html#get-file-archive

This resolves nix-community#56 and nix-community/emacs-overlay#128.

Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
kennyballou added a commit to kennyballou/emacs2nix that referenced this issue Apr 12, 2021
Use similar archive fetch URL as [fetchgitlab][0] from [nixpkgs][1].
This archive scheme is documented in the [GitLab API docs][2].

[0]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchgitlab/default.nix

[1]: https://github.com/NixOS/nixpkgs

[2]: https://docs.gitlab.com/ce/api/repositories.html#get-file-archive

This resolves nix-community#56 and nix-community/emacs-overlay#128.

Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
kennyballou added a commit to kennyballou/emacs2nix that referenced this issue Apr 14, 2021
Use similar archive fetch URL as [fetchgitlab][0] from [nixpkgs][1].
This archive scheme is documented in the [GitLab API docs][2].

[0]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchgitlab/default.nix

[1]: https://github.com/NixOS/nixpkgs

[2]: https://docs.gitlab.com/ce/api/repositories.html#get-file-archive

This resolves nix-community#56 and nix-community/emacs-overlay#128.

Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
ttuegel pushed a commit to nix-community/emacs2nix that referenced this issue Apr 21, 2021
Use similar archive fetch URL as [fetchgitlab][0] from [nixpkgs][1].
This archive scheme is documented in the [GitLab API docs][2].

[0]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchgitlab/default.nix

[1]: https://github.com/NixOS/nixpkgs

[2]: https://docs.gitlab.com/ce/api/repositories.html#get-file-archive

This resolves #56 and nix-community/emacs-overlay#128.

Signed-off-by: Kenny Ballou <kb@devnulllabs.io>
@kennyballou
Copy link
Author

Now that nix-community/emacs2nix#57 is merged, do we wait for the next update to resolve GitLab packages, or is there some related work in the repository that is necessary to use the new version of emacs2nix?

@kennyballou
Copy link
Author

Now that ttuegel/emacs2nix#57 is merged, do we wait for the next update to resolve GitLab packages, or is there some related work in the repository that is necessary to use the new version of emacs2nix?

Based on the contents in bb8d4e9, there's work to be done.

@kennyballou
Copy link
Author

This has been interesting to unravel, I'm not a hundred percent I've completely untangled how this is all coming together. But I believe this issue will be resolved when/if NixOS/nixpkgs#120354 merges.

@kennyballou
Copy link
Author

NixOS/nixpkgs#120354 has merged. I will wait for the next melpa update to be committed and will close this issue after verifying the expected results.

@kennyballou
Copy link
Author

As of b717ab8, this looks to be resolved.

@chvp
Copy link

chvp commented May 4, 2021

I'm still having issues with modus-themes, but maybe that's due to #125? The version it tries to build is 20210503.1941, but the version on melpa is 20210504.902.

@matthew-piziak
Copy link

@chvp I had trouble with modus themes myself. I ended up loading them my .emacs instead, using this use-package form:

  (use-package modus-themes
    :straight (modus-themes :type git :host gitlab :repo "protesilaos/modus-themes")
    :init
    (modus-themes-load-themes)
    :hook (after-init . modus-themes-load-vivendi))

@kennyballou
Copy link
Author

@chvp: I think you're right that it's related to #125; I also saw this issue with the modus-themes. Looking at the commits on the project, a new commit was added a few hours after the auto update finished, likely triggering the unstable URL path.

That said, the new head, 0e85ce5, looks to have the right commit and builds for modus-themes. (I also noticed that melpa-stable version of modus-themes doesn't build either.)

@chvp
Copy link

chvp commented May 5, 2021

It does seem to work now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants