Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare admins #408

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Cloudflare admins #408

merged 1 commit into from
Jan 24, 2023

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jan 24, 2023

Another part of #399

@zowoq
Copy link
Contributor

zowoq commented Jan 24, 2023

Not sure if you want to merge or close #404.

@zimbatm
Copy link
Member Author

zimbatm commented Jan 24, 2023

github doesn't handle PR chains very well. 404 should be merged first.

@zowoq
Copy link
Contributor

zowoq commented Jan 24, 2023

Rebased due to merge conflict.

Seems this removes account_id from the cloudflare members?

@zowoq zowoq mentioned this pull request Jan 24, 2023
11 tasks
@zimbatm
Copy link
Member Author

zimbatm commented Jan 24, 2023

thanks, this happens sometimes when the mapping is not done properly. the provider wants us to move to an account_id per resource anyways so I added it.

@zimbatm zimbatm merged commit 040f73a into master Jan 24, 2023
@zimbatm zimbatm deleted the cloudflare-admins branch January 24, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants