fix: only generate a version file if nvidiaVersion isn't set #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using nixGL in a flake, it would be convenient to use the
auto.nixGLDefault
attribute to generate anixGL
wrapper (previously I was generatingnixGLnvidia-<version>
.auto.nixGLDefault
can't be used in a flake because there are two impure operations, first is generating the version file, and second is fetching the sha256 for the runfile.This PR prevents those two operations from occuring if the user provides
nvidiaVersion
andnvidiaHash
arguments to nixGLHunk 1: prevents the version file generation if
nvidiaVersion
is passed, see the comment in the code for why this worksHunk 2: simply passes
nvidiaHash
tonvidiaPackages
, in the casenvidiaHash
is null, this should fetch the hash as before.