Add a way to wrap nix derivations with makeWrapper #133
Conversation
| paths = [ drv ]; | ||
| buildInputs = [ pkgs.makeWrapper ]; | ||
| postBuild = '' | ||
| # This will break if wrapProgram is ever changed, so fingers crossed |
There was a problem hiding this comment.
Why are not using wrapProgram directly?
There was a problem hiding this comment.
As far as I know, there's no way to tell makeShellWrapper to make an actual wrapper in the sense that nixGL wraps stuff, so I overrode it with what we need here.
I still wanted to use wrapProgram though because it has some logic to correctly deal with multiple layers of wrapping.
If you think it would be better I'll inline it.
There was a problem hiding this comment.
Double wrapping as you describe it should be avoided as much as possible as it is very hard to get right. I think it would probably be an idea to modify the existing wrappers to fit your usecase to create one wrapped binary.
There was a problem hiding this comment.
I might be misinterpreting that, but my reading of the code is that this is what wrapProgram is for. I'm actually wrapping mixxx twice myself (nixGL and adding LD_LIBRARY_PATH for jack), and I'm pretty sure the package adds another wrapper itself.
This is obviously not optimal, but it makes things somewhat composable.
Anyways, I don't think we really have something to argue about here. I just found this solution for myself and thought it would be valuable to share.
I'm personally a bit hesitant to propose using wrapProgram directly because it will not work on packages which use a wrapper internally.
It's your decision what to put in the readme, I'm just offering a suggestion from my personal point of view.
There was a problem hiding this comment.
As far as I know, there's no way to tell
makeShellWrapperto make an actual wrapper in the sense thatnixGLwraps stuff, so I overrode it with what we need here. I still wanted to usewrapProgramthough because it has some logic to correctly deal with multiple layers of wrapping. If you think it would be better I'll inline it.
You should be able to do it the same way that electron programs are handled in nixpkgs
makeWrapper ${electron}/bin/electron $out/bin/${pname} \
--inherit-argv0 \
--add-flags $out/share/${pname}/resources/appAlso please use makeBinaryWrapper, inherit-argv0 works better with it AFAIK.
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
I can't be bothered to remember adding
nixGLand I'm sure I'm not the only one.