Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable gets declared as unused when used in path interpolation #472

Closed
Libadoxon opened this issue Apr 28, 2024 · 2 comments · Fixed by #490
Closed

Variable gets declared as unused when used in path interpolation #472

Libadoxon opened this issue Apr 28, 2024 · 2 comments · Fixed by #490
Labels
bug Something isn't working

Comments

@Libadoxon
Copy link

image

@inclyc inclyc added the bug Something isn't working label Apr 28, 2024
@inclyc
Copy link
Member

inclyc commented Apr 28, 2024

This issue is easy to fix. Let's leave this to new contributors.

Modify this line:

[[nodiscard]] ChildVector children() const override { return {}; }

To this:

[[nodiscard]] ChildVector children() const override { return {Parts.get()}; }

Bonus: if the change is test-covered.

@inclyc inclyc added the good first issue Good for newcomers label Apr 28, 2024
@inclyc inclyc changed the title Variable gets delcared as unused when used in path substitution Variable gets declared as unused when used in path interpolation Apr 28, 2024
@inclyc
Copy link
Member

inclyc commented May 2, 2024

I'll take this.

@inclyc inclyc removed the good first issue Good for newcomers label May 2, 2024
inclyc added a commit that referenced this issue May 2, 2024
inclyc added a commit that referenced this issue May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants