Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixd/definition: goto definition for any evaluated non-pos-discarded values #117

Merged
merged 1 commit into from
Jun 13, 2023
Merged

nixd/definition: goto definition for any evaluated non-pos-discarded values #117

merged 1 commit into from
Jun 13, 2023

Conversation

inclyc
Copy link
Member

@inclyc inclyc commented Jun 12, 2023

Fixes: #116
Inspired-by: oxalica/nil#9 (comment)

Actually the current impl is just do the comment. However we do not need to start repl or whatever.

@inclyc inclyc marked this pull request as draft June 12, 2023 11:08
@inclyc inclyc marked this pull request as ready for review June 12, 2023 12:05
@inclyc inclyc added the enhancement New feature or request label Jun 13, 2023
@inclyc inclyc force-pushed the nixd/completion/options-example branch from 614b71f to 6c10097 Compare June 13, 2023 03:47
@inclyc inclyc changed the base branch from nixd/completion/options-example to nixd/definition/package June 13, 2023 03:54
inclyc
inclyc commented Jun 13, 2023
View reviewed changes
lib/nixd/src/ServerWorker.cpp Outdated Show resolved Hide resolved
@inclyc inclyc force-pushed the nixd/definition/package branch 4 times, most recently from 95efc42 to 16e4e6a Compare June 13, 2023 05:08
Base automatically changed from nixd/definition/package to main June 13, 2023 05:09
@inclyc inclyc mentioned this pull request Jun 13, 2023
Closed
4 tasks
@inclyc inclyc merged commit 093a484 into main Jun 13, 2023
@inclyc inclyc deleted the nixd/definition/value branch June 13, 2023 05:29
inclyc added a commit that referenced this pull request Jun 14, 2023
@inclyc
docs: update the README to show new feature introduced in #117 #113
8541262 
Link: #117
Link: #113
Fixes: #122
a-kenji pushed a commit to a-kenji/nixd that referenced this pull request Nov 3, 2023
@inclyc @a-kenji
docs: update the README to show new feature introduced in nix-communi…
a5288de 
…ty#117 nix-community#113

Link: nix-community#117
Link: nix-community#113
Fixes: nix-community#122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixd/definition: goto definition for any evaluated non-pos-discarded values
1 participant
@inclyc