[main] Update flake.lock & generated files #2002
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -28,7 +28,7 @@ let | |||
| { | |||
| name = "astro"; | |||
| description = "astrols for Astro"; | |||
| package = pkgs.nodePackages."@astrojs/language-server"; | |||
| package = pkgs.astro-language-server; | |||
There was a problem hiding this comment.
How long has pkgs.astro-language-server existed? Will this be a breaking change for any users who's pkgs is slightly older than ours?
There was a problem hiding this comment.
Since this exact bump.
We end up on the same question as last time: should we start handling multiple distinct revisions of nixpkgs ?
Here sure, we could set package = pkgs.astro-language-server or pkgs.nodePackages."@astrojs/language-server";...
There was a problem hiding this comment.
My ideal would be to evaluate the package options lazily, so that this only affects users that are using the module.
I appreciate if you don't think it's worth the effort, but I think it's more user-friendly to have the fallback; especially given most of our users aren't using our nixpkgs lock - either because they aren't using standalone or because they have a follows.
There was a problem hiding this comment.
Sure, I think here we can go for this minor tweak.
There was a problem hiding this comment.
I've opened #2004 for the more general issue
There was a problem hiding this comment.
Here is the nixpkgs issue for the package: NixOS/nixpkgs#309100
The change was merged 5th, August.
There was a problem hiding this comment.
I opened a bug report NixOS/nixpkgs#333677
Flake lock file updates:
• Updated input 'git-hooks':
'github:cachix/git-hooks.nix/06939f6b7ec4d4f465bf3132a05367cccbbf64da' (2024-08-05)
→ 'github:cachix/git-hooks.nix/c7012d0c18567c889b948781bc74a501e92275d1' (2024-08-09)
• Updated input 'home-manager':
'github:nix-community/home-manager/afc892db74d65042031a093adb6010c4c3378422' (2024-08-02)
→ 'github:nix-community/home-manager/b3d5ea65d88d67d4ec578ed11d4d2d51e3de525e' (2024-08-07)
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/cb9a96f23c491c081b38eab96d22fa958043c9fa' (2024-08-04)
→ 'github:NixOS/nixpkgs/5e0ca22929f3342b19569b21b2f3462f053e497b' (2024-08-09)
• Updated input 'nuschtosSearch':
'github:NuschtOS/search/aa5f6246565cc9b1e697d2c9d6ed2c842b17fff6' (2024-08-04)
→ 'github:NuschtOS/search/1016f4620e321c12ff1dbcd464e9de889e302d1c' (2024-08-08)
GaetanLepage
force-pushed
the
update/main
branch
from
8ff21b7
to
728c69c
Compare
GaetanLepage
force-pushed
the
update/main
branch
from
728c69c
to
f13bdef
Compare
|
|
I can't reproduce this on this branch: $ format
warning: ignoring untrusted substituter 'https://nix-community.cachix.org', you are not a trusted user.
Run `man nix.conf` for more information on the `substituters` configuration option.
WARN format: no formatter for path: .editorconfig
traversed 686 files
emitted 686 files for processing
formatted 661 files (0 changed) in 47.822s |
Ok, maybe some impurities on my side then. |
- [ ] try again when astrojs node packages is fixed nix-community/nixvim#2002
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f13bdef |
- [ ] try again when astrojs node packages is fixed nix-community/nixvim#2002
- [ ] try again when astrojs node packages is fixed nix-community/nixvim#2002
- [ ] try again when astrojs node packages is fixed nix-community/nixvim#2002
- [ ] try again when astrojs node packages is fixed nix-community/nixvim#2002
Flake lockfile
Generate
No changes
Fixes #2010