Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Dependency updates #49

Merged
merged 8 commits into from
Sep 8, 2021
Merged

Dependency updates #49

merged 8 commits into from
Sep 8, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 31, 2021

This hopefully fixes the memory leak from #33. Please refer to the commit messages for further details.

Please note that I only did some brief tests. I'd like to run this on my setup for a few days before merging this. Further testers are of course fairly welcome, so we can hopefully find out if my theory regarding #33 is correct :)

@Ma27
Perform cargo update
0b6fce2
@Ma27
flake.lock: Update
4e18056 
Flake input changes:

* Updated 'naersk': 'github:nmattia/naersk/ce273fa593dcc94a629d0d869f07d96d2b337e37' -> 'github:nmattia/naersk/df71f5e4babda41cd919a8684b72218e2e809fa9'
* Updated 'naersk/nixpkgs': 'github:NixOS/nixpkgs/2247d824fe07f16325596acc7faa286502faffd1' -> 'path:/nix/store/jg618dszb08c67a4x8lbh4lq4y3wr8nv-source?lastModified=1630102403&narHash=sha256-AIo%2fbHUi5fwSIid0DStpm60OYjjchJUCPndHKGL6bbY=&rev=2cc15f0c910057656f510f55bbec9a0437e33b69'
* Updated 'nixpkgs': 'github:NixOS/nixpkgs/2247d824fe07f16325596acc7faa286502faffd1' -> 'github:nixos/nixpkgs/74d017edb6717ad76d38edc02ad3210d4ad66b96'
* Updated 'utils': 'github:numtide/flake-utils/5021eac20303a61fafe17224c087f5519baed54d' -> 'github:numtide/flake-utils/997f7efcb746a9c140ce1f13c72263189225f482'
@Ma27
flake: pin nixpkgs to current stable
3cd3f0b
@Ma27
Update dependencies
4909cb1 
The main motiviation is to get `crossbeam-channel` at at least 0.5.1 as
this appears to fix a memory like[1] which is probably the root-cause of
our own memory issues[2].

This also included some changes to the LSP type-system as a few more
changes in the LSP protocol are now incorporated, such as a
clarification that numbers are usually unsigned 32bit rather than
64bit[3].

[1] https://github.com/crossbeam-rs/crossbeam/blob/crossbeam-channel-0.5.1/crossbeam-channel/CHANGELOG.md#version-051
[2] nix-community#33
[3] gluon-lang/lsp-types@f654090
@Ma27 Ma27 requested a review from aaronjanse August 31, 2021 21:45
@Ma27 Ma27 mentioned this pull request Aug 31, 2021
Closed
@Ma27
Copy link
Member Author

Ma27 commented Aug 31, 2021

Hmm, weird, nix build -f . -I nixpkgs=https://github.com/NixOS/nixpkgs-channels/archive/nixpkgs-unstable.tar.gz -L works fine locally. @Mic92 since you seen to have implemented this pipeline initially, do you have an idea what's up there? :)

@Ma27 Ma27 added this to the 0.2.0 milestone Sep 1, 2021
@Mic92
Copy link
Member

Mic92 commented Sep 1, 2021 •
edited
Loading

Hmm, weird, nix build -f . -I nixpkgs=https://github.com/NixOS/nixpkgs-channels/archive/nixpkgs-unstable.tar.gz -L works fine locally. @Mic92 since you seen to have implemented this pipeline initially, do you have an idea what's up there? :)

nixpkgs-channel is no longer updated, try to switch https://github.com/NixOS/nixpkgs/archive/nixpkgs-unstable.tar.gz

@Ma27
Copy link
Member Author

Ma27 commented Sep 2, 2021

OK the problem was that the nixpkgs entry for naersk was substituted from my local registry which contains a store-path pointing to a personal nixpkgs fork.

aaronjanse
aaronjanse approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@aaronjanse aaronjanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Ma27! This works well for me. I'm unable to reproduce the memory leak, so I don't know whether this PR fixes the issue, but I think it's good anyway to keep dependencies up-to-date.

Feel free to merge this if it has been working for you without issues :-)

@aaronjanse
Copy link
Member

Maybe the memory leak is located in another dependency, such as rowan? There was a rowan memory leak fix merged recently, but I doubt that something as severe as "uses all available memory" would silently be in something like rowan that's used by a lot of people

@Mic92
Copy link
Member

Mic92 commented Sep 8, 2021

Have you tried running one of the heap profilers out there, like heaptrack?
I just found https://github.com/koute/bytehound I have not tested it though.

@Ma27
Copy link
Member Author

Ma27 commented Sep 8, 2021

I just found https://github.com/koute/bytehound I have not tested it though.

Thanks for the hint, not sure though how much it'll help if the leak is not properly reproducible, but it's definitely worth a shot.

Will try to resume my work on this leak-problem at one of the next days, going to merge this now since it appears to work fine :)

@Ma27 Ma27 merged commit a9f24f2 into nix-community:master Sep 8, 2021
@Ma27 Ma27 deleted the dependency-updates branch September 8, 2021 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronjanse aaronjanse aaronjanse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Ma27 @Mic92 @aaronjanse