expose modules list #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @zowoq |
zimbatm
force-pushed
the
expose-module-list
branch
from
813d243
to
814c45e
Compare
|
I think we'll need some sort of structure like that. What do you think? |
Mic92
reviewed
Dec 31, 2022
default.nix
Outdated
Comment on lines
3
to
5
| profiles-common = import ./profiles/common.nix; | ||
| profiles-server = import ./profiles/server.nix; | ||
| profiles-desktop = import ./profiles/desktop.nix; |
There was a problem hiding this comment.
I think these are actually our main modules while the below behave more like mixins that you can add on top.
There was a problem hiding this comment.
Something that indicates that you should add one of these and than some of the below would be nice.
There was a problem hiding this comment.
On the other hand already the categories profiles and roles on its own are confusing enough..
There was a problem hiding this comment.
Good point. I moved things around a bit.
zimbatm
force-pushed
the
expose-module-list
branch
3 times, most recently
from
b4623c0
to
f7b0748
Compare
Make the modules list available outside of flakes and prefix them.
zimbatm
force-pushed
the
expose-module-list
branch
from
f7b0748
to
5ac1773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the modules list available outside of flakes and prefix them.