Add PTRACE_SYSEMU and PTRACE_SYSEMU_SINGLESTEP support #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @voidc, got busy with work and this dropped off my plate :) |
jabedude
reviewed
Sep 28, 2020
src/sys/ptrace/linux.rs
Outdated
| /// In case the tracee is stopped at a syscall, the syscall will not be executed. | ||
| /// Optionally, the signal specified by `sig` is delivered to the tracee upon continuation. | ||
| #[cfg(all(target_os = "linux", target_env = "gnu", any(target_arch = "x86", target_arch = "x86_64")))] | ||
| pub fn step_or_sysemu<T: Into<Option<Signal>>>(pid: Pid, sig: T) -> Result<()> { |
There was a problem hiding this comment.
What do you think about fn sysemu_singlestep?
There was a problem hiding this comment.
I renamed it to sysemu_step to be in line with the naming of the step method.
|
I rebased. Could anybody review? |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1249.
I think @jabedude was working on this, but as there was no progress since May I went ahead and implemented it myself.
I'm not completely sure about the cfg gates. Could we enable the functions for more targets?
I'm also open for suggestions of better names for the new functions.