Declare the MSRV in Cargo.toml #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new feature in Cargo 1.56.0, currently in beta. Once Nix's MSRV is >= 1.56.0, this feature will prevent future problems like the bitflags 1.3.0 fiasco. Issue nix-rust#1491 Issue nix-rust#1510 Issue nix-rust#1548 Issue nix-rust#1555
This was referenced Oct 23, 2021
rivy
added a commit
to rivy/rs.coreutils
that referenced
this pull request
Nov 14, 2021
- possibly causing the CI codecov break for MacOS - ref: [MacOS: Undefined symbols for architecture x86_64](nix-rust/nix#1588) - ref: [Cannot have nix 0.20 and 0.23 in same package due to conflicting bitflags requirement](nix-rust/nix#1555) - ref: [Declare the MSRV in Cargo.toml](nix-rust/nix#1561)
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 15, 2021
1561: Declare the MSRV in Cargo.toml r=rtzoeller a=asomers This is a new feature in Cargo 1.56.0, currently in beta. Once Nix's MSRV is >= 1.56.0, this feature will prevent future problems like the bitflags 1.3.0 fiasco. Issue #1491 Issue #1510 Issue #1548 Issue #1555 Co-authored-by: Alan Somers <asomers@gmail.com>
|
Build failed: |
|
I'll look into the failure, but at first glance it's coming from within rustc. I'm tempted to say we should skip the check for this PR/until it's fixed, since DragonFly is a tier 3 target. |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature in Cargo 1.56.0, currently in beta. Once Nix's
MSRV is >= 1.56.0, this feature will prevent future problems like the
bitflags 1.3.0 fiasco.
Issue #1491
Issue #1510
Issue #1548
Issue #1555