Disable pwritev and preadv for 'macos' (fixes #1588) #1590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivy
force-pushed
the
fix.macos-missing-symbols
branch
from
e4faa09
to
a40f3e0
Compare
…::uio::pwritev()` tests
rivy
force-pushed
the
fix.macos-missing-symbols
branch
from
a40f3e0
to
d33ffa9
Compare
|
I've added matching OS restrictions to the matching tests to help surface any future breakage. |
rivy
force-pushed
the
fix.macos-missing-symbols
branch
2 times, most recently
from
2a01bdb
to
d33ffa9
Compare
rivy
added a commit
to rivy/rs.coreutils
that referenced
this pull request
Nov 16, 2021
- a PR has been submitted to 'nix'; ref: <nix-rust/nix#1590>
asomers
requested changes
Nov 17, 2021
There was a problem hiding this comment.
Removing those functions is not the solution to whatever problem you're experiencing. Those functions do exist on OSX, at least according to libc. If they in fact don't, or if they need to be linked with a different library, then you need to fix this issue in libc. We can't merge this PR until you've root-caused the issue.
|
I believe that you have already root-caused the issue by noting that the current version fails for OSX v10.15 (see #1588). |
rivy
added a commit
to rivy/rs.coreutils
that referenced
this pull request
Nov 17, 2021
- a PR has been submitted to 'nix'; ref: <nix-rust/nix#1590>
rivy
added a commit
to rivy/rs.coreutils
that referenced
this pull request
Nov 17, 2021
- a PR has been submitted to 'nix'; ref: <nix-rust/nix#1590>
rivy
added a commit
to rivy/rs.coreutils
that referenced
this pull request
Nov 17, 2021
- a PR has been submitted to 'nix'; ref: <nix-rust/nix#1590>
rivy
added a commit
to rivy/rs.coreutils
that referenced
this pull request
Nov 20, 2021
- a PR has been submitted to 'nix'; ref: <nix-rust/nix#1590>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1588.
Please merge; we're using a patched vendored version until you're able to fix this...