Don't deref uninit addrs in pack_mhdr_to_receive
#1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new method to `SockaddrLikePriv` to get a pointer to some underlying `libc::sockaddr` from a pointer to some type. This avoids dereferencing uninitialized values during `pack_mhdr_to_receive`, which is called from `MultiHeaders::preallocate` and `recvmsg`. Because this is a private trait, this is not a semver-breaking change.
|
Can we get this rolled into a release? |
|
Ping! @asomers, could we get this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new method to
SockaddrLikePrivto get a pointer to some underlyinglibc::sockaddrfrom a pointer to some type. This avoids dereferencing uninitialized values duringpack_mhdr_to_receive, which is called fromMultiHeaders::preallocateandrecvmsg.Because this is a private trait, this is not a semver-breaking change.
Fixes #1990