Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fanotify API wrappers #2194

Merged
merged 11 commits into from
Nov 23, 2023
Merged

Add fanotify API wrappers #2194

merged 11 commits into from
Nov 23, 2023

Conversation

ad0
Copy link
Contributor

@ad0 ad0 commented Nov 16, 2023

What does this PR do

It adds linux fanotify API support: wrappers for libc fanotify_init and fanotify_mark functions.
Note that it requires libc version 0.2.150 since it introduces necessary fanotify constants (rust-lang/libc#3408).

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@ad0 ad0 marked this pull request as ready for review November 16, 2023 14:11
@ad0 ad0 force-pushed the fanotify branch 2 times, most recently from c3c044d to 63acd98 Compare November 17, 2023 09:29
src/sys/fanotify.rs Outdated Show resolved Hide resolved
src/sys/fanotify.rs Outdated Show resolved Hide resolved
src/sys/fanotify.rs Outdated Show resolved Hide resolved
src/sys/fanotify.rs Outdated Show resolved Hide resolved
src/sys/fanotify.rs Show resolved Hide resolved
src/sys/fanotify.rs Outdated Show resolved Hide resolved
src/sys/fanotify.rs Outdated Show resolved Hide resolved
src/sys/fanotify.rs Outdated Show resolved Hide resolved
src/sys/fanotify.rs Outdated Show resolved Hide resolved
src/sys/fanotify.rs Show resolved Hide resolved
@SteveLauC
Copy link
Member

Hi, thanks for your interest in contributing to Nix, I have left some comments on this PR:)

@ad0
Copy link
Contributor Author

ad0 commented Nov 19, 2023

Hi, thank you for the detailled review, I'll treat your comments asap!

src/sys/fanotify.rs Outdated Show resolved Hide resolved
src/sys/fanotify.rs Outdated Show resolved Hide resolved
@ad0 ad0 marked this pull request as draft November 20, 2023 08:37
@ad0 ad0 force-pushed the fanotify branch 3 times, most recently from 8d6d0d2 to 63c2620 Compare November 20, 2023 10:13
src/fcntl.rs Outdated Show resolved Hide resolved
@SteveLauC
Copy link
Member

Let's merge this PR, mind removing the WIP/Draft status?

@ad0 ad0 marked this pull request as ready for review November 21, 2023 06:16
@SteveLauC SteveLauC added this pull request to the merge queue Nov 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2023
@SteveLauC
Copy link
Member

That tier3 (armv7-unknown-linux-uclibceabihf) CI failure is probably a nightly Rust bug, see also this comment

@SteveLauC SteveLauC added this pull request to the merge queue Nov 23, 2023
Merged via the queue into nix-rust:master with commit 755c66d Nov 23, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants