Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sockopt Ipv6Ttl for apple targets #2287

Merged
merged 4 commits into from
Feb 25, 2024

Conversation

SteveLauC
Copy link
Member

@SteveLauC SteveLauC commented Jan 13, 2024

What does this PR do

Add socket option Ipv6Ttl for apple targets.

Checklist:

  • I have read CONTRIBUTING.md

  • I have written necessary tests and rustdoc comments

    There is a test (test_ttl_opts()) for Ipv4Ttl and Ipv6Ttl, but the support of Ipv4Ttl for apple will be added in Support for socket options to get/set TOS/TTL info #2203, which means that I cannot enable that test in this PR, will do it when both of these PRs get merged.

  • A change log has been added if this PR modifies nix's API

@SteveLauC
Copy link
Member Author

Temporarily enabled that test for apple targets in this commit, and CI passed.

@SteveLauC
Copy link
Member Author

Hi @asomers, could you please take a look at this PR when you have time cause I want to push #2203 forward

@SteveLauC SteveLauC added this pull request to the merge queue Feb 25, 2024
Merged via the queue into nix-rust:master with commit b171eeb Feb 25, 2024
35 checks passed
@SteveLauC SteveLauC deleted the sockopt_Ipv6Ttl_apple branch February 25, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants