-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unaligned read panic on macos #2311
fix: unaligned read panic on macos #2311
Conversation
c2ce2fd
to
27a24d4
Compare
607b0f3
to
4315c10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only contains changes to the doc test. Where is the actual code change?
4315c10
to
5f85f02
Compare
Wanted to check if misalignment was triggered in CI but wasn't the case so I factorize BSD and Apple test The separate test case was relevant only locally on my computer |
5f85f02
to
77e1305
Compare
Did you successfully reproduce it in CI? Currently, there is no macOS aarch64 CI in Nix, but since GitHub Action has introduced this, we can enable it if needed.
|
No i didn't success, maybe because of that, but maybe because memory alignment depends of the OS and lot other random variables, locally it only happens on some groups and i'm not sure if it will be same groups in CI. |
0516a69
to
246948f
Compare
1faf396
to
d3543e7
Compare
d3543e7
to
7141269
Compare
don't trigger in CI, i tried 13 groups but none trigger while lot of them crash on my Mac, maybe because of the virtualization of macos? |
That's possible. BTW, does this patch fix the issue on your host? |
Definitely, yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you say when you are able to release a new version including this fix? We are having users who get this error and would like to use the fix in the dependencies. |
Hi, I think I will release 0.28.0 in the near future (possibly within this week) |
What does this PR do
Checklist:
CONTRIBUTING.md