-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added if_indextoname function. #2340
Conversation
Hi, thanks for your interest in contributing to Nix! CI failures are not related, so no worries, I will take a closer look at this PR this weekend:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this PR looks good! I have left some comments on those minor style things, thanks again for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
CI issues fixed in #2344, looks like you need to rebase your branch:) |
I just rebased and MacOS is still failing. |
Thanks! |
What does this PR do
Checklist:
CONTRIBUTING.md