Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added if_indextoname function. #2340

Merged
merged 5 commits into from
Mar 24, 2024
Merged

Conversation

Frostie314159
Copy link
Contributor

@Frostie314159 Frostie314159 commented Mar 21, 2024

What does this PR do

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@SteveLauC
Copy link
Member

Hi, thanks for your interest in contributing to Nix!

CI failures are not related, so no worries, I will take a closer look at this PR this weekend:)

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this PR looks good! I have left some comments on those minor style things, thanks again for this!

src/net/if_.rs Show resolved Hide resolved
src/net/if_.rs Outdated Show resolved Hide resolved
src/net/if_.rs Outdated Show resolved Hide resolved
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC
Copy link
Member

CI issues fixed in #2344, looks like you need to rebase your branch:)

@Frostie314159
Copy link
Contributor Author

Frostie314159 commented Mar 24, 2024

I just rebased and MacOS is still failing.

@SteveLauC SteveLauC added this pull request to the merge queue Mar 24, 2024
Merged via the queue into nix-rust:master with commit 945910d Mar 24, 2024
36 checks passed
@SteveLauC
Copy link
Member

Thanks!

@Frostie314159 Frostie314159 deleted the if_indextoname branch March 25, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants