feat: Use type parameters to allow {get,set}regset
to use different register set structs
#2373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Previous implementations of
{get,set}regset
are incorrect when register set value is anything other thanNT_PRSTATUS
. This PR adds the ability to return corresponding struct to the value using type parametersS: RegisterSet
, so the behaviour is correct.Added
NT_PRSTATUS
as well asNT_PRFPREG
types so we can also probe floating-point registers. Other register sets may be inspected as well, such as arch-specific vector registers, but I don't have a use case right now, and it is easy to implement afterwards with the framework in this PR.Checklist:
CONTRIBUTING.md
This is an improvement over #2044, so changelog remains the same.