Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing signals. #361

Merged
merged 1 commit into from
May 6, 2016
Merged

Add missing signals. #361

merged 1 commit into from
May 6, 2016

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented Apr 25, 2016

In preparation of turning them into an enumeration.

@fiveop
Copy link
Contributor Author

fiveop commented Apr 25, 2016

Added rust-lang/libc#265 to get this to work.

@fiveop fiveop mentioned this pull request Apr 25, 2016
@fiveop
Copy link
Contributor Author

fiveop commented Apr 30, 2016

Now, all we need is a new libc version for this.

@fiveop
Copy link
Contributor Author

fiveop commented May 5, 2016

This should compile now. Will @homu run another test, if we accept it?

@kamalmarhubi
Copy link
Member

kamalmarhubi commented May 6, 2016

Could you bump the libc requirement in Cargo.toml to the release that includes these names? Once you do that, r=me.

Re @homu, we'll find out!

@fiveop
Copy link
Contributor Author

fiveop commented May 6, 2016

@homu r=@kamalmarhubi

@homu
Copy link
Contributor

homu commented May 6, 2016

📌 Commit c1334f5 has been approved by @kamalmarhubi

homu added a commit that referenced this pull request May 6, 2016
Add missing signals.

In preparation of turning them into an enumeration.
@homu
Copy link
Contributor

homu commented May 6, 2016

⌛ Testing commit c1334f5 with merge a5936e4...

@homu
Copy link
Contributor

homu commented May 6, 2016

☀️ Test successful - status

@homu homu merged commit c1334f5 into nix-rust:master May 6, 2016
@fiveop fiveop deleted the missing_signals branch May 7, 2016 12:21
homu added a commit that referenced this pull request Jun 12, 2016
Signal enum

This is work in progress. I post this pull request as a request for discussion. I mark the lines I have doubts or ideas about.

Ignore the first commit. It is the same as PR #361, which I wanted to base this change off.
homu added a commit that referenced this pull request Jun 27, 2016
Signal enum

This is work in progress. I post this pull request as a request for discussion. I mark the lines I have doubts or ideas about.

Ignore the first commit. It is the same as PR #361, which I wanted to base this change off.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants