Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sys::time::{time_t, suseconds_t} public #968

Merged
merged 1 commit into from Nov 8, 2018
Merged

Conversation

@jmmv
Copy link
Contributor

@jmmv jmmv commented Nov 5, 2018

This allows handling the return values of other public functions
(such as TimeVal's tv_sec and tv_usec) without having to pull in
these types from libc (which is ugly if a project is trying to
use nix exclusively to avoid libc's unsafety).

This allows handling the return values of other public functions
(such as TimeVal's tv_sec and tv_usec) without having to pull in
these types from libc (which is ugly if a project is trying to
use nix exclusively to avoid libc's unsafety).
@jmmv jmmv force-pushed the jmmv:time-types branch from 0c12953 to 6a0ff23 Nov 7, 2018
@asomers
asomers approved these changes Nov 8, 2018
Copy link
Member

@asomers asomers left a comment

Yeah, this seems good. We definitely don't want to force consumers to import libc directly.

bors r+

bors bot added a commit that referenced this pull request Nov 8, 2018
Merge #968
968: Make sys::time::{time_t, suseconds_t} public r=asomers a=jmmv

This allows handling the return values of other public functions
(such as TimeVal's tv_sec and tv_usec) without having to pull in
these types from libc (which is ugly if a project is trying to
use nix exclusively to avoid libc's unsafety).

Co-authored-by: Julio Merino <julio@meroh.net>
@bors bors bot merged commit 6a0ff23 into nix-rust:master Nov 8, 2018
4 checks passed
4 checks passed
bors Build succeeded
Details
buildbot/nix-rust/nix amd64_fbsd11 Build done.
Details
buildbot/nix-rust/nix i386_fbsd11 Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants