Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Techstack-beta] Site-wide: Banners missing the hover state #1321

Closed
samueldr opened this issue Mar 8, 2024 · 0 comments · Fixed by #1326
Closed

[Techstack-beta] Site-wide: Banners missing the hover state #1321

samueldr opened this issue Mar 8, 2024 · 0 comments · Fixed by #1326
Labels
design About the design refresh work new-techstack-beta This tag marks issues with the new tech stack during preview phase

Comments

@samueldr
Copy link
Member

samueldr commented Mar 8, 2024 •
edited
Loading

#1305 was closed with #1315 though incomplete.

(Not pictured: how it is clickable... hard to screenshot... But the whole light blue part is clickable, see the pointer cursor when you hover.)

The whole banner being clickable shouldn't come as a surprise for mouse users. This is why the cursor should change to the pointer (hand pointer).
@samueldr samueldr added the design About the design refresh work label Mar 8, 2024
@thilobillerbeck thilobillerbeck mentioned this issue Mar 8, 2024
Merged
@thilobillerbeck thilobillerbeck linked a pull request Mar 8, 2024 that will close this issue
[Textstack Beta] fix dividers, images, box sizes etc. #1326
Merged
@thilobillerbeck thilobillerbeck added the new-techstack-beta This tag marks issues with the new tech stack during preview phase label Mar 8, 2024
garbas pushed a commit that referenced this issue Mar 12, 2024
@thilobillerbeck
[Textstack Beta] fix dividers, images, box sizes etc. (#1326)
73098d6 
- fixes #1324 
- fixes #1322 
- fixes #1321 
- fixes #1258 
- fixes #1295 
- fixes #1307 
- fixes #1288
@garbas garbas closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design About the design refresh work new-techstack-beta This tag marks issues with the new tech stack during preview phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Textstack Beta] fix dividers, images, box sizes etc. NixOS/nixos-homepage
3 participants
@garbas @samueldr @thilobillerbeck