Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't label PRs with moved expressions with has: package(new) #116

Open
Ma27 opened this issue Mar 13, 2018 · 2 comments
Open

Don't label PRs with moved expressions with has: package(new) #116

Ma27 opened this issue Mar 13, 2018 · 2 comments

Comments

@Ma27
Copy link
Member

Ma27 commented Mar 13, 2018

Have a look at the following PR for instance: NixOS/nixpkgs#36934

This PR did a minor rename change, however the PR was labeled to contain a new package which might be a bit misleading especially when the PR aims to fix a package that might be relevant for the upcoming release.

@grahamc
Copy link
Member

grahamc commented Mar 14, 2018

Hmm so the root of the issue is: https://github.com/NixOS/nixpkgs/pull/36934/files#diff-2afbba83e1b14f9e0c304c769831a0e2R232 the code sees that a new attribute has been created and thinks it is a new package.

Perhaps what could be done is determining if the outpath of the new package is known by other attributes as well...

@Ma27
Copy link
Member Author

Ma27 commented Mar 15, 2018

Makes sense. Please keep in mind that I might lack time to find a suitable solution ATM (busy with exams actually :/), but I'll poke you if I find some to start work to avoid duplicated efforts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants