Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review comment should link directly to attempt log #49

Closed
jtojnar opened this issue Jan 30, 2018 · 2 comments
Closed

Review comment should link directly to attempt log #49

jtojnar opened this issue Jan 30, 2018 · 2 comments

Comments

@jtojnar
Copy link
Member

jtojnar commented Jan 30, 2018

Currently the full log link in the review comment links to the main (-ofborg-) tab. This is not very helpful when there are many logs and you want to view a particular failure.
@grahamc
Copy link
Member

grahamc commented Feb 1, 2018

This feature is done and deployed. Builders will take some time to update, and so some builder's links will not link directly to a log. Once all builders update, all log links will be to the exact attempt.

@grahamc grahamc closed this as completed Feb 1, 2018
@grahamc
Copy link
Member

grahamc commented Feb 1, 2018

Example of where it has worked: NixOS/nixpkgs#34481 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grahamc @jtojnar