Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tests.* listed as changed paths #664

Open
ShamrockLee opened this issue Dec 10, 2023 · 2 comments
Open

Build tests.* listed as changed paths #664

ShamrockLee opened this issue Dec 10, 2023 · 2 comments

Comments

@ShamrockLee
Copy link

ShamrockLee commented Dec 10, 2023

OfBorg currently build packages whose expression is changed directly by the PR, but not the affected downstream packages. But we could consider building changed derivations under tests.* even if their expressions are not changed directly, as they are meant to be tested.

I'm not sure if we would like to avoid running NixOS tests (as they would be expensive) inside OfBorg. If so, it would be better to get a way to detect if a test derivation is a NixOS tests, instead of opting out everything under tests.

Update: test cases under pkgs.tests are all package tests.

@Artturin
Copy link
Member

Artturin commented Dec 10, 2023

pkgs.tests doesn't contain nixos tests nor is it meant to.

EDIT:
You meant passthru.tests? There's no way to indirectly get what's changed in passthru without recursing everything.

@ShamrockLee
Copy link
Author

pkgs.tests doesn't contain nixos tests nor is it meant to.

Thank you for explaining. I confused the term "NixOS tests" with package tests implemented with runNixOSTest (e.g. tests.trivial-builders.references).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants