Basic Python3 support #23
Conversation
|
OK, I believe this is ready to go; it switches on python 2 and 3 everywhere so it should be usable with either now. |
|
Thank you very much for the contribution, and sorry for the long hiatus! |
| find_package(PythonInterp 3 REQUIRED) | ||
| find_package(PythonLibs 3 REQUIRED) | ||
| if(PY3) | ||
| set(Python_ADDITIONAL_VERSIONS 3.5 3.4) |
There was a problem hiding this comment.
Would this also work with 3.3 (which I think is still moderately common)?
There was a problem hiding this comment.
Probably, I just have no machine handy to test it on.
Also mention it in the README.
I have no way to test this but it should work and it's a fairly common version still.
|
Looks good, thanks again! |
|
This actually breaks neovim setup that supports both python2 and python3 together. It looks like python 2 version is being built (as I don't have python3-dev installed), but then vim portion detects that python3 is available and decides to use it (but there is no package for python3 built!). |
Fixes #23 for neovim. I think.
|
Hi @maximsch2, can you try the current master? |
|
@nixprime I've tried it and it doesn't solve the issue (one thing is that it is calling Is it possible to try calling both python2 and python3 versions in the |
Addresses #22 on my machine. cc @burke
I don't expect this to get accepted as-is, but it compiles and runs using vim-with-python3 on my machine, so I figured it would be worth publishing as a first step.
Still todo:
vim --version