Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] PERMBU fails when n_samples is not None #86

Closed
AzulGarza opened this issue Oct 20, 2022 · 0 comments · Fixed by #143
Closed

[BUG] PERMBU fails when n_samples is not None #86

AzulGarza opened this issue Oct 20, 2022 · 0 comments · Fixed by #143
Assignees
@kdgutier

Comments

@AzulGarza
Copy link
Member

PERMBU throws an error when n_samples is different than y_insample.shape[1].

hierarchicalforecast/hierarchicalforecast/methods.py

Lines 941 to 942 in 0a2d6c7

if n_samples is None:
n_samples = y_insample.shape[1]

@kdgutier kdgutier self-assigned this Jan 4, 2023
@kdgutier kdgutier linked a pull request Jan 4, 2023 that will close this issue
[BUG] PERMBU unique_id order and num_samples #143
Merged
@kdgutier kdgutier closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdgutier kdgutier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] PERMBU unique_id order and num_samples Nixtla/hierarchicalforecast
3 participants
@mergenthaler @AzulGarza @kdgutier