Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getter for the CityObject's ID node #50

Merged
merged 2 commits into from
May 19, 2024

Conversation

lmichaelis-fhg
Copy link
Contributor

This patch adds a convenience getter for the gml:id attribute of city objects.

This patch adds a convenience getter for the `gml:id` attribute of city objects.
@@ -20,6 +20,10 @@ class CityObject {
return new Envelope(envelopeNode)
}

get id() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the return type doc?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it.

@njam njam merged commit ea89b8f into njam:master May 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants