Sections #6
Merged
Sections #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .gitmodules
# Conflicts: # .gitmodules
This is useful when testing.
| @@ -4,8 +4,11 @@ | |||
| #include "ENDFtk/implementation/SectionBase.hpp" | |||
| #include "ENDFtk/implementation/UnivariateTabulation.hpp" | |||
|
|
|||
| namespace ENDFtk{ | |||
There was a problem hiding this comment.
Isn't it weird clang doesn't complain about this?
|
|
||
| int MT() const { return MT_; } | ||
| const int& MT() { return MT_; } |
|
Approved! |
Unfortunately, we are reducing the test coverage.
jlconlin
pushed a commit
that referenced
this pull request
May 8, 2017
3f39eb5 Merge pull request #9 from njoy/README 7f027c0 Fixing issue related to Python3. 3aa9553 strictness project specific 8bd1daa subproject to is_subproject 3356ae0 executable installation only when not subproject 7263e94 fix for libraries a3e5adb constrain configuration types 470c254 directory installation correction 48ccecc regex error 44886a1 spacing in linker flags a7c72a9 Updating README following pull request comments. cc89730 bugfix 6457dca rounding math removed and coverage extension 6c360a0 correction 35a3091 coverage in tests necessary for header-only libraries edd43bb local changes 4b4f943 Clarifying need for include path. 156cb72 Being more specific 2e5a0a7 Finished with updating commands. 47cd119 Working on README. 1dce0f6 Adding README file. cbd8068 apple clang 8fe650a clang compliant debug flags 06fc1dc config e6fb36d more updates 982fa8b update b07c58c split d840594 directory installation 5a03ea0 whitespace 4103d38 dependencies 75d0f1d subproject linking bug 5e9ac83 missung header extension 2657253 ignore path default c486ab6 only verify version if version is available 9507100 bug 65038bd wrong order cd179c1 bug 2cb9403 precedence d9b76f1 bug in degenerate case e86e3fd need more for subproject 5faa5b8 another bug 2493440 circular d854e3e bug 50877ee correction d6bac61 underscore keys f93301c tweaks 2ff8fc0 external projects are hard 5bd040d Merge pull request #8 from njoy/refactor/generalize ebb26a2 consider subprojects 0fd9a10 Merge pull request #6 from njoy/refactor/generalize 0d9c813 manual merge 22daf46 Merge pull request #5 from njoy/refactor/generalize d19af43 njoy2016 testing/debugging 1527f74 debugged using njoy 64aca82 refactor dce72af Merge pull request #3 from njoy/feature/collect_subprojects d51b28a long lines 3164c69 don't build subproject executables bae56cd correction c10fdbd Correctly handle multiple test resources f7c0ece offline script e4b5ce8 better fortran module organization fbd3876 removed project specific files aad4441 testing work git-subtree-dir: metaconfigure git-subtree-split: 3f39eb5f25fbeeabf2102d529d726fea314c14a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of what a Section is, as well as the definition of Section<3>