Feature/double quotes #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There should a corresponding set of change to the manual such that, in each instance that specifies a single quote delimited string is required. to state double quote and asterisk delimited strings are permissible. |
apmccartney
previously approved these changes
Aug 11, 2018
| @@ -0,0 +1,8 @@ | |||
| bool isQuote( char c ){ | |||
| if ( ( c == '\'' ) or ( c == '*' ) or ( c == '"' ) ){ | |||
There was a problem hiding this comment.
stares suspiciously at asterisk
|
Could you link to a successful build on EC2? |
|
I thought it was building just find on Jenkins, but now it looks like it was just building the |
|
Here is a successful build as reported by Jenkins for @apmccartney |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the capability to use double quotes in addition to single quotes to delimit strings.