Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube trailer video link not found #15

Closed
nk932714 opened this issue Jan 10, 2019 · 4 comments
Closed

youtube trailer video link not found #15

nk932714 opened this issue Jan 10, 2019 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@nk932714
Copy link
Owner

in some cases youtube trailer link is not provided by yify api. So in mobile devices if you click on link that will keep opening browser.
@nk932714 nk932714 added bug Something isn't working enhancement New feature or request labels Jan 10, 2019
@nk932714
Copy link
Owner Author

adding some intelligence.

  1. if you are using a mobile device and click on trailer link it will open the trailer in mobile YouTube app.
  2. if you are using a PC then trailer will open in popup. SO you don't need to go to YouTube to watch the trailer and come back again and again. (will save your time)
  3. To exit from popup you need to click anywhere outside YouTube video link.

nk932714 added a commit that referenced this issue Feb 18, 2019
@nk932714
#15 adding some intelligence
d8f3559 
1. if you are using a mobile device and click on trailer link it will open the trailer in mobile YouTube app.

2. if you are using a PC then trailer will open in popup. SO you don't need to go to YouTube to watch the trailer and come back again and again. (will save your time)

3. To exit from popup you need to click anywhere outside YouTube video link.
nk932714 added a commit that referenced this issue Feb 18, 2019
@nk932714
#15 adding some intelligence
425643c 
1. if you are using a mobile device and click on trailer link it will open the trailer in mobile YouTube app.

2. if you are using a PC then trailer will open in popup. SO you don't need to go to YouTube to watch the trailer and come back again and again. (will save your time)

3. To exit from popup you need to click anywhere outside YouTube video link.
(little improvement) (div defined outside the pageContent div)
nk932714 added a commit that referenced this issue Feb 18, 2019
@nk932714
#15 adding some intelligence
af9ca32 
1. if you are using a mobile device and click on trailer link it will open the trailer in mobile YouTube app.

2. if you are using a PC then trailer will open in popup. SO you don't need to go to YouTube to watch the trailer and come back again and again. (will save your time)

3. To exit from popup you need to click anywhere outside YouTube video link.
nk932714 added a commit that referenced this issue Feb 18, 2019
@nk932714
#15 adding some intelligence(fix)
05c37f8 
(fix youtube wasn't opening in popup)
1. if you are using a mobile device and click on trailer link it will open the trailer in mobile YouTube app.

2. if you are using a PC then trailer will open in popup. SO you don't need to go to YouTube to watch the trailer and come back again and again. (will save your time)

3. To exit from popup you need to click anywhere outside YouTube video link.
@nk932714
Copy link
Owner Author

bugs found - not opening in mobile view.
TODO- add two links

@nk932714
Copy link
Owner Author

nk932714 commented Feb 19, 2019 •
edited
Loading

small fix needed yt trailer add array number

nk932714 added a commit that referenced this issue Feb 19, 2019
@nk932714
#15 small fixes
a19bb16 
added separate button for mobile view.
nk932714 added a commit that referenced this issue Feb 19, 2019
@nk932714
#15 fix
4f4a273
@nk932714
Copy link
Owner Author

i hope now everything is fixed. Leave this issue open for some days . If anyone find any error please write here

@nk932714 nk932714 closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nk932714