Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete(). #2

Merged
merged 2 commits into from
May 5, 2024
Merged

Add delete(). #2

merged 2 commits into from
May 5, 2024

Conversation

btimby
Copy link
Contributor

@btimby btimby commented Apr 7, 2024

I needed this so I added it. If you require anything else to merge this, let me know.

nklsw
nklsw requested changes Apr 29, 2024
View reviewed changes
Copy link
Owner

@nklsw nklsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution! It looks good, but I would ask you to make two minor adjustments before merging.

tests/test_messages.py Outdated Show resolved Hide resolved
mailhog/main.py Outdated Show resolved Hide resolved
@btimby
Copy link
Contributor Author

btimby commented May 4, 2024

Sure thing. Sorry it took so long, have been busy!

@btimby btimby requested a review from nklsw May 5, 2024 17:25
nklsw
nklsw approved these changes May 5, 2024
View reviewed changes
Copy link
Owner

@nklsw nklsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nklsw nklsw merged commit 1b6d489 into nklsw:main May 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nklsw nklsw nklsw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btimby @nklsw