Add VRF algorithm in crypto #491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NoelBright <noel.n.bright@gmail.com>
add 'Proof' member in SigChainElem. Signed-off-by: NoelBright <noel.n.bright@gmail.com>
Signed-off-by: NoelBright <noel.n.bright@gmail.com>
yilunzhang
reviewed
Apr 26, 2019
pb/sigchain.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| signature, proof := crypto.GenerateVrf(srcPrivKey, hash[:]) |
There was a problem hiding this comment.
since there is no error returned, what if srcPrivKey is invalid?
There was a problem hiding this comment.
Only need to be 64 bytes.
yilunzhang
reviewed
Apr 26, 2019
Add returncode err in GenerateVrf Signed-off-by: NoelBright <noel.n.bright@gmail.com>
yilunzhang
approved these changes
Apr 26, 2019
|
Yes, it has passed my test already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Add VRF algorithm in crypto.
Update SigChain and SigChainElem proto structure.
Use new sigchain to relay message.
Type (put an
xwhere ever applicable)Checklist
Please put an
xagainst the checkboxes. Write a small comment explaining if itsN/A(not applicable)Extra information
Any extra information related to this pull request.