Rob/framework support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 15, 2013 10:47
…der or you can specify "frameworks-directory". Frameworks are linked and added to a Copy Files build phase.
| makeKitProject :: [KitContents] -> Maybe String -> KitProject | ||
| makeKitProject kitsContents depsOnlyConfig = | ||
| let pf = createProjectFile kitsContents | ||
| header = createHeader kitsContents | ||
| config = createConfig kitsContents | ||
| -- TODO: Make this specify an xcconfig data type | ||
| depsConfig = "#include \"" ++ xcodeConfigFile ++ "\"\n\nSKIP_INSTALL=YES\n\n" ++ fromMaybe "" depsOnlyConfig | ||
| depsConfig = "#include \"" ++ xcodeConfigFile ++ "\"\n\nSKIP_INSTALL=YES\nSDKROOT=iphoneos\n\n" ++ fromMaybe "" depsOnlyConfig |
There was a problem hiding this comment.
It was hardcoded before, into the actual project file (see the changes to ProjectFileTemplate.hs). I've moved it here so that the DepsOnly.xcconfig file can have #include-ed xcconfig files which override it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for custom frameworks