Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Dev server crashes when there is a syntax error solidjs/solid-start#1222 #100

Closed
nksaraf opened this issue Jan 6, 2024 · 4 comments · Fixed by #214
Closed

[Bug?]: Dev server crashes when there is a syntax error solidjs/solid-start#1222 #100

nksaraf opened this issue Jan 6, 2024 · 4 comments · Fixed by #214
Labels
bug Something isn't working

Comments

@nksaraf
Copy link
Owner

nksaraf commented Jan 6, 2024

solidjs/solid-start#1222

@nksaraf nksaraf added the bug Something isn't working label Jan 6, 2024
@semiautomatix
Copy link

semiautomatix commented Jan 31, 2024

I'd like to see the server revert and remain running until the change is corrected.

This is particularly frustrating when using Auto Save in VSCode, as the code isn't necessary correct on each save (e.g. might be awaiting a closing tag).

@nksaraf
Copy link
Owner Author

nksaraf commented Jan 31, 2024

Fair. This needs to be fixed

@DoctorRyner
Copy link

@nksaraf this is a deal breaker for my team, maybe you can point me to the problematic code and I will make a PR

@nksaraf
Copy link
Owner Author

nksaraf commented Feb 11, 2024

one issue is that because there are a few places your files get parsed, we have to handle the error case everywhere, which is fine, just needs some thorough trial and fixing.

I had found some cases, for example the fsRouter parses files to check for exports, this probably errors out esbuild which is not handled gracefully.

nksaraf added a commit that referenced this issue Feb 12, 2024
fix: catch errors in fs-router fixes #100
This was referenced Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants