Switch from esm to @httptoolkit/esm #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37. I've just reused the @types/esm types here, since they should be the same and I haven't worked out how to modify esm to add them in easily directly over there (the build & publish setup is much more complicated than you'd expect).
This change also removes workarounds here that I think were since fixed within esm-wallaby (here and here specifically).
I don't have any specific interesting test cases to confirm those, but I can do things like
require('.')('node:fs')
with no problem, and everything works correctly for other modules, so I assume that's all working nicely now.