updated tests to fix bugs with empty arrays not cloning

nktnet1 · Oct 12, 2023 · 4a57bbc · 4a57bbc
1 parent c412424
commit 4a57bbc
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 2 deletions.
diff --git a/src/clone.ts b/src/clone.ts
@@ -24,7 +24,8 @@ const objectClone: CloneFn = <T>(obj: T): T => {
     return obj;
   }
   if (Array.isArray(obj)) {
-    return obj.map(objectClone) as T;
+    // Empty array doesn't clone properly in Jest with just map
+    return (obj.length === 0 ? [] : [...obj.map(objectClone)]) as T;
   }
   const cloneObj: Record<string, any> = {};
   for (const [key, value] of Object.entries(obj)) {

diff --git a/tests/options/options.test.js b/tests/options/options.test.js
@@ -24,7 +24,15 @@ test('callback function upon success', () => {
   jewire('../variables/variables', {
     callback: (_, hE) => {
       expect(hE.symbols.variables).toStrictEqual([
-        'numberFive', 'array', 'shallowObject', 'arrayOfObjects', 'deeplyNestedObject',
+        'numberFive',
+        'array',
+        'shallowObject',
+        'arrayOfObjects',
+        'deeplyNestedObject',
+        'nullVariable',
+        'emptyObject',
+        'emptyArray',
+        'undefinedVariable',
       ]);
     }
   });

diff --git a/tests/variables/variables.js b/tests/variables/variables.js
@@ -19,3 +19,11 @@ const deeplyNestedObject = {
     },
   }
 };
+
+const nullVariable = null;
+
+const emptyObject = {};
+
+const emptyArray = [];
+
+const undefinedVariable = undefined;
diff --git a/tests/variables/variables.test.js b/tests/variables/variables.test.js
@@ -6,13 +6,18 @@ const {
   shallowObject,
   arrayOfObjects,
   deeplyNestedObject,
+  nullVariable,
+  emptyObject,
+  emptyArray,
+  undefinedVariable,
 } = jewire('./variables');
 
 test('variables are imported correctly', () => {
   expect(numberFive).toStrictEqual(5);
 });
 
 test('arrays are imported correctly', () => {
+  expect(array).toBeInstanceOf(Array);
   expect(array).toStrictEqual([1, 2, 3]);
 });
 
@@ -35,3 +40,21 @@ test('nested object passes strict equality', () => {
 test('Array of Objects', () => {
   expect(arrayOfObjects).toStrictEqual([{ name: 'Tam', age: 22 }, { name: 'Spam', age: 23 }]);
 });
+
+test('Null variable', () => {
+  expect(nullVariable).toStrictEqual(null);
+});
+
+test('Empty object', () => {
+  expect(emptyObject).toBeInstanceOf(Object);
+  expect(emptyObject).toStrictEqual({});
+});
+
+test('Empty array', () => {
+  expect(emptyArray).toBeInstanceOf(Array);
+  expect(emptyArray).toStrictEqual([]);
+});
+
+test('Undefined variable', () => {
+  expect(undefinedVariable).toStrictEqual(undefined);
+});