Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Backport the PLAMS <= 1.5.1 Molecule.get_formula method #212

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Dec 2, 2021

Xref #209

Backport in preparation for the changes introduced in SCM-NV/PLAMS@6100836,
which switches Hill-system-based formula notation rather than the previous purelly alphabetical notation.

@BvB93 BvB93 added the Maintenance Improvements to pre-existing features label Dec 2, 2021
@BvB93 BvB93 added this to the CAT 0.10.1 milestone Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #212 (72d90c1) into master (23a3466) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   67.43%   67.46%   +0.03%     
==========================================
  Files          48       48              
  Lines        3900     3904       +4     
  Branches      699      701       +2     
==========================================
+ Hits         2630     2634       +4     
  Misses       1114     1114              
  Partials      156      156              
Impacted Files Coverage Δ
CAT/attachment/ligand_anchoring.py 89.74% <100.00%> (ø)
CAT/data_handling/mol_import.py 73.22% <100.00%> (+0.11%) ⬆️
CAT/multi_ligand.py 77.77% <100.00%> (ø)
CAT/utils.py 70.43% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a3466...72d90c1. Read the comment docs.

@BvB93 BvB93 merged commit b78488d into master Dec 2, 2021
@BvB93 BvB93 deleted the get_formula branch December 2, 2021 15:28
BvB93 pushed a commit to nlesc-nano/nano-CAT that referenced this pull request Dec 2, 2021
BvB93 pushed a commit to nlesc-nano/nano-CAT that referenced this pull request Dec 2, 2021
BvB93 pushed a commit to nlesc-nano/data-CAT that referenced this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Improvements to pre-existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant