Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PairIterator interface for performance #35

Closed
nlfiedler opened this issue Oct 24, 2013 · 0 comments
Closed

Remove PairIterator interface for performance #35

nlfiedler opened this issue Oct 24, 2013 · 0 comments
Assignees
Labels

Comments

@nlfiedler
Copy link
Owner

Based on Ewen's analysis of various Go iterator patterns, using an interface with an interator struct implementation is much slower than an iterator struct implementation without the corresponding iterator interface. That is, just remove PairIterator the interface and promote pairIterator the struct to "PairIterator".

@ghost ghost assigned nlfiedler Dec 21, 2013
nlfiedler added a commit that referenced this issue Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant